Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connecting to TiDB with VS Code: added instructions on how to install SQLTools MySQL/MariaDB/… #16133

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Connecting to TiDB with VS Code: added instructions on how to install SQLTools MySQL/MariaDB/… #16133

merged 2 commits into from
Jan 30, 2024

Conversation

kenudeh
Copy link
Contributor

@kenudeh kenudeh commented Jan 12, 2024 •
edited
Loading

…TiDB from VS Code extensions tab

First-time contributors' checklist

What is changed, added or deleted? (Required)

I added a method of installing the SQLTools MySQL/MariaDB/TiDB extension directly from VS Code's extensions tab. The existing methods do not cover this, despite it being a common way to add extensions among developers.

The new method involves clicking on the extensions tab within VS Code, entering the extension's name, and selecting the extension from the displayed search result. I compressed the instructions into two short sentences.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

https://docs.pingcap.com/tidbcloud/dev-guide-gui-vscode-sqltools#connect-to-tidb

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. labels Jan 12, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 12, 2024

Welcome @kenudeh!

It looks like this is your first PR to pingcap/docs 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/docs. 😃

@ti-chi-bot ti-chi-bot bot added area/develop This PR relates to the area of TiDB App development. missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 12, 2024
@qiancai qiancai linked an issue Jan 12, 2024 that may be closed by this pull request
Debug TiDB Cloud Documentation: Connect to TiDB with Visual Studio Code #16033
Closed
@qiancai qiancai requested a review from Icemap January 12, 2024 05:34
@qiancai qiancai added the translation/doing This PR's assignee is translating this PR. label Jan 12, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Jan 12, 2024
dveeden
dveeden approved these changes Jan 15, 2024
View reviewed changes
develop/dev-guide-gui-vscode-sqltools.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 15, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 15, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 15, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-15 07:14:30.19544819 +0000 UTC m=+167311.759745880: ☑️ agreed by dveeden.
  • 2024-01-15 09:28:07.836823356 +0000 UTC m=+175329.401121043: ☑️ agreed by Icemap.

@rpaik
Copy link
Member

rpaik commented Jan 29, 2024

@Icemap is anything else needed here for this PR?

@Icemap
Copy link
Member

Icemap commented Jan 29, 2024

@Icemap is anything else needed here for this PR?

IMO, we need to wait for the author @kenudeh to have some feedback on that comment above. And we need another "LGTM" from the doc team.

@qiancai qiancai added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.3 needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Jan 30, 2024
@qiancai
Copy link
Collaborator

qiancai commented Jan 30, 2024

/retest

@qiancai
Copy link
Collaborator

qiancai commented Jan 30, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 30, 2024
@ti-chi-bot ti-chi-bot bot merged commit b516674 into pingcap:master Jan 30, 2024
8 of 9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.6: #16386.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 30, 2024
Merged
18 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #16387.

This was referenced Jan 30, 2024
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #16388.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.3: #16389.

This was referenced Jan 30, 2024
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.4: #16390.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #16391.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 30, 2024
Merged
18 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Jan 30, 2024
@ti-chi-bot
Connecting to TiDB with VS Code: added instructions on how to install…
cd39d8a 
… SQLTools MySQL/MariaDB/… (#16133) (#16388)
ti-chi-bot bot pushed a commit that referenced this pull request Jan 30, 2024
@ti-chi-bot
Connecting to TiDB with VS Code: added instructions on how to install…
c3aecf5 
… SQLTools MySQL/MariaDB/… (#16133) (#16387)
ti-chi-bot bot pushed a commit that referenced this pull request Jan 30, 2024
@ti-chi-bot
Connecting to TiDB with VS Code: added instructions on how to install…
f334b12 
… SQLTools MySQL/MariaDB/… (#16133) (#16390)
ti-chi-bot bot pushed a commit that referenced this pull request Jan 30, 2024
@ti-chi-bot
Connecting to TiDB with VS Code: added instructions on how to install…
035bc4f 
… SQLTools MySQL/MariaDB/… (#16133) (#16389)
ti-chi-bot bot pushed a commit that referenced this pull request Jan 30, 2024
@ti-chi-bot
Connecting to TiDB with VS Code: added instructions on how to install…
2507a81 
… SQLTools MySQL/MariaDB/… (#16133) (#16386)
ti-chi-bot bot pushed a commit that referenced this pull request Jan 30, 2024
@ti-chi-bot
Connecting to TiDB with VS Code: added instructions on how to install…
22ca73b 
… SQLTools MySQL/MariaDB/… (#16133) (#16391)
@qiancai qiancai mentioned this pull request Jan 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dveeden dveeden dveeden approved these changes

@Icemap Icemap Icemap approved these changes

@hfxsd hfxsd hfxsd approved these changes

@qiancai qiancai qiancai approved these changes

Assignees

@Icemap Icemap

Labels
approved area/develop This PR relates to the area of TiDB App development. contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/doing This PR's assignee is translating this PR.
Projects
2024 TiDB Docs Dash Issue List | 2024 TiDB 文档挑战赛任务列表
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Debug TiDB Cloud Documentation: Connect to TiDB with Visual Studio Code
7 participants
@kenudeh @rpaik @Icemap @qiancai @ti-chi-bot @dveeden @hfxsd